Skip to content

[5.2] Show a warning when there are due tasks#43491

Merged
pe7er merged 15 commits intojoomla:5.2-devfrom
zero-24:due_tasks
Jul 2, 2024
Merged

[5.2] Show a warning when there are due tasks#43491
pe7er merged 15 commits intojoomla:5.2-devfrom
zero-24:due_tasks

Conversation

@zero-24
Copy link
Copy Markdown
Contributor

@zero-24 zero-24 commented May 19, 2024

Summary of Changes

Show next run, show list by next run and show a warning when there are due tasks

Testing Instructions

  • Load the scheduled tasks
  • Notice the ordeing by title and the missing Next Run field from the list
  • Apply this patch
  • Open that page again
  • Confrim that the Next Run field is there as well as its orderd by that field so the next task to run will be shown first

image

  • Go to the database -> #__scheduler_tasks take one task and set the next_execution date to someting in the past
    image

  • Reload the scheduled tasks list and notice the message that comes up
    image

  • Use the "Test " button

  • Notice the message is gone, it will come up of course as soon as there is another due task which is not run

Actual result BEFORE applying this Pull Request

No way to detect not run tasks or get to know the next tasks to trigger.

Expected result AFTER applying this Pull Request

  1. Warning when there are due tasks
  2. Option to show the next time a task should run
  3. Default ordeing to show the next task to run first

Link to documentations

Please select:

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.1-dev labels May 19, 2024
brianteeman
brianteeman reviewed May 19, 2024
View reviewed changes
zero-24
zero-24 commented May 19, 2024
View reviewed changes
Quy
Quy reviewed May 21, 2024
View reviewed changes
@zero-24 @QuyTon
Update administrator/language/en-GB/com_scheduler.ini
2cc9b52 
Co-authored-by: Quy <quy@nomonkeybiz.com>
@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 21, 2024 •
edited
Loading

On initial load of list view, sort indicator does not match dropdown.

43491

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented May 22, 2024

Please try again @Quy

Quy
Quy reviewed May 23, 2024
View reviewed changes
@richard67
Copy link
Copy Markdown
Member

richard67 commented Jun 2, 2024

@zero-24 Is this a bug fix or a new feature?
If bug fix, then the bug may also apply to 4.4-dev and so should be fixed there, too (or only there and later be merged up to 5.1-dev). The bug might not be as visible on the 4.4-dev branch as it is here because in 4.4 we did not use the task scheduler for cyclic core stuff, but it might apply also there.
But if new feature: Shouldn't it be made for 5.2-dev?

@zero-24 zero-24 changed the base branch from 5.1-dev to 5.2-dev June 2, 2024 18:54
@zero-24 zero-24 requested a review from laoneo as a code owner June 2, 2024 18:54
@zero-24 zero-24 changed the title [5.1] Show show a warning when there are due tasks [5.2] Show show a warning when there are due tasks Jun 2, 2024
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Jun 2, 2024
@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Jun 2, 2024

Moved to 5.2 looking forward to tests on this PR so it can be merged.

@joomla-cms-bot joomla-cms-bot removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Jun 9, 2024
@Quy Quy removed the PR-5.1-dev label Jun 25, 2024
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jun 26, 2024

I have tested this item ✅ successfully on c850fd8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43491.

1 similar comment
@alikon
Copy link
Copy Markdown
Contributor

alikon commented Jun 27, 2024

I have tested this item ✅ successfully on c850fd8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43491.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Jun 27, 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43491.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 27, 2024
@Quy Quy removed the PR-5.1-dev label Jun 27, 2024
@laoneo laoneo changed the title [5.2] Show show a warning when there are due tasks [5.2] Show a warning when there are due tasks Jun 28, 2024
@pe7er pe7er self-assigned this Jul 2, 2024
@pe7er pe7er merged commit 3254a87 into joomla:5.2-dev Jul 2, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 2, 2024
@pe7er
Copy link
Copy Markdown
Contributor

pe7er commented Jul 2, 2024

Thanks @zero-24 !

@zero-24 zero-24 deleted the due_tasks branch July 2, 2024 10:49
@Quy Quy added this to the Joomla! 5.2.0 milestone Jul 2, 2024
@jgerman-bot jgerman-bot mentioned this pull request Jul 3, 2024
Closed
@joomlapl-bot joomlapl-bot mentioned this pull request Jul 3, 2024
Closed
@brbrbr brbrbr mentioned this pull request Jul 7, 2024
Closed
Kostelano added a commit to JPathRu/localisation that referenced this pull request Sep 19, 2024
@Kostelano
Новое в Joomla 5.2.0-Beta3
4893fc1 
joomla/joomla-cms#43232 +
joomla/joomla-cms#43378 +
joomla/joomla-cms#43216 +
joomla/joomla-cms#43260 +
joomla/joomla-cms#43386 +
joomla/joomla-cms#43575 +
joomla/joomla-cms#43491 +
joomla/joomla-cms#43760 - (upmerge, внесено в 5.1х)
joomla/joomla-cms#43247 +
joomla/joomla-cms#43579 +
joomla/joomla-cms#43690 +
joomla/joomla-cms#43829 +
joomla/joomla-cms#43840 +
joomla/joomla-cms#43841 +
joomla/joomla-cms#43885 - (upmerge, только для др. пакетов)
joomla/joomla-cms#43223 +
joomla/joomla-cms#43810 - (только для en-GB)
joomla/joomla-cms#43898 +
joomla/joomla-cms#43432 +
joomla/joomla-cms#43870 +
joomla/joomla-cms#42850 +
joomla/joomla-cms#43937 - (upmerge, только для др. пакетов)
joomla/joomla-cms#43862 +
joomla/joomla-cms#43975 +
joomla/joomla-cms#43910 +
joomla/joomla-cms#43965 +
joomla/joomla-cms#43738 +
joomla/joomla-cms#43814 +
joomla/joomla-cms#44000 +
joomla/joomla-cms#44050 + (upmerge, с 4.4.9)
joomla/joomla-cms#43966 +
joomla/joomla-cms#44065 +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quy Quy Quy left review comments

@laoneo laoneo Awaiting requested review from laoneo

+1 more reviewer

@brianteeman brianteeman brianteeman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pe7er pe7er

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla! 5.2.0

Development

Successfully merging this pull request may close these issues.

8 participants

@zero-24 @Quy @richard67 @alikon @pe7er @brianteeman @joomla-cms-bot @QuyTon